Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1317

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c0e14b with merge base ecc628d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 18, 2024
Copy link
Contributor

@vmpuri vmpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit: are we able to change the filename? chat.jpg is quite generic - if the old app image is outdated anyways, are we able to retain the same filename and just delete the old image?

@kirklandsign
Copy link
Contributor Author

Just a nit: are we able to change the filename? chat.jpg is quite generic - if the old app image is outdated anyways, are we able to retain the same filename and just delete the old image?

That's because we have already used chat.png in ET wiki 🤣

Maybe we update, both ET and torchchat, next time when we revisit this?

@Jack-Khuu Jack-Khuu merged commit 1ba88ad into main Oct 21, 2024
52 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants