Skip to content

Temporarily disable CP tests #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Temporarily disable CP tests #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
180 changes: 90 additions & 90 deletions tests/integration_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,28 +296,28 @@ def build_test_list():
"hsdp",
ngpu=4,
),
OverrideDefinitions(
[
[
"--experimental.context_parallel_degree=4",
"--experimental.context_parallel_rotate_method='allgather'",
]
],
"CP (allgather)",
"cp_allgather",
ngpu=4,
),
OverrideDefinitions(
[
[
"--experimental.context_parallel_degree=4",
"--experimental.context_parallel_rotate_method='alltoall'",
]
],
"CP (alltoall)",
"cp_alltoall",
ngpu=4,
),
# OverrideDefinitions(
# [
# [
# "--experimental.context_parallel_degree=4",
# "--experimental.context_parallel_rotate_method='allgather'",
# ]
# ],
# "CP (allgather)",
# "cp_allgather",
# ngpu=4,
# ),
# OverrideDefinitions(
# [
# [
# "--experimental.context_parallel_degree=4",
# "--experimental.context_parallel_rotate_method='alltoall'",
# ]
# ],
# "CP (alltoall)",
# "cp_alltoall",
# ngpu=4,
# ),
OverrideDefinitions(
[
[
Expand All @@ -330,74 +330,74 @@ def build_test_list():
"hsdp+tp",
ngpu=8,
),
OverrideDefinitions(
[
[
"--training.data_parallel_shard_degree=2",
"--experimental.context_parallel_degree=2",
]
],
"FSDP+CP",
"fsdp+cp",
ngpu=4,
),
OverrideDefinitions(
[
[
"--training.data_parallel_shard_degree=1",
"--training.data_parallel_replicate_degree=2",
"--experimental.context_parallel_degree=2",
]
],
"HSDP+CP (with dp_shard)",
"hsdp+cp_without_dp_shard",
ngpu=4,
),
OverrideDefinitions(
[
[
"--training.data_parallel_shard_degree=2",
"--training.data_parallel_replicate_degree=2",
"--experimental.context_parallel_degree=2",
]
],
"HSDP+CP (without dp_shard)",
"hsdp+cp_with_dp_shard",
ngpu=8,
),
OverrideDefinitions(
[
[
"--training.data_parallel_shard_degree=2",
"--training.tensor_parallel_degree=2",
"--experimental.context_parallel_degree=2",
]
],
"FSDP+TP+CP",
"fsdp+tp+cp",
ngpu=8,
),
OverrideDefinitions(
[
[
"--checkpoint.enable_checkpoint",
"--training.tensor_parallel_degree=2",
"--experimental.context_parallel_degree=2",
"--training.enable_cpu_offload",
"--optimizer.early_step_in_backward",
],
[
"--training.tensor_parallel_degree=2",
"--experimental.context_parallel_degree=2",
"--training.data_parallel_replicate_degree=2",
"--training.enable_cpu_offload",
"--optimizer.early_step_in_backward",
],
],
"Enable CPU Offload, Optimizer in backward with TP, DP, CP",
"cpu_offload+opt_in_bwd+TP+DP+CP",
ngpu=8,
),
# OverrideDefinitions(
# [
# [
# "--training.data_parallel_shard_degree=2",
# "--experimental.context_parallel_degree=2",
# ]
# ],
# "FSDP+CP",
# "fsdp+cp",
# ngpu=4,
# ),
# OverrideDefinitions(
# [
# [
# "--training.data_parallel_shard_degree=1",
# "--training.data_parallel_replicate_degree=2",
# "--experimental.context_parallel_degree=2",
# ]
# ],
# "HSDP+CP (with dp_shard)",
# "hsdp+cp_without_dp_shard",
# ngpu=4,
# ),
# OverrideDefinitions(
# [
# [
# "--training.data_parallel_shard_degree=2",
# "--training.data_parallel_replicate_degree=2",
# "--experimental.context_parallel_degree=2",
# ]
# ],
# "HSDP+CP (without dp_shard)",
# "hsdp+cp_with_dp_shard",
# ngpu=8,
# ),
# OverrideDefinitions(
# [
# [
# "--training.data_parallel_shard_degree=2",
# "--training.tensor_parallel_degree=2",
# "--experimental.context_parallel_degree=2",
# ]
# ],
# "FSDP+TP+CP",
# "fsdp+tp+cp",
# ngpu=8,
# ),
# OverrideDefinitions(
# [
# [
# "--checkpoint.enable_checkpoint",
# "--training.tensor_parallel_degree=2",
# "--experimental.context_parallel_degree=2",
# "--training.enable_cpu_offload",
# "--optimizer.early_step_in_backward",
# ],
# [
# "--training.tensor_parallel_degree=2",
# "--experimental.context_parallel_degree=2",
# "--training.data_parallel_replicate_degree=2",
# "--training.enable_cpu_offload",
# "--optimizer.early_step_in_backward",
# ],
# ],
# "Enable CPU Offload, Optimizer in backward with TP, DP, CP",
# "cpu_offload+opt_in_bwd+TP+DP+CP",
# ngpu=8,
# ),
OverrideDefinitions(
[
[
Expand Down