Skip to content

Conversation

@kiersten-stokes
Copy link
Contributor

This PR adds a root image path to the sphinx_gallery_conf dict according to these instructions given in the Sphinx Gallery docs. It also updates the corresponding relative paths in the image directives in certain Blitz, Basics, and Youtube tutorials.

Related to #791. I'm not going to link a 'closing' keyword yet, as this PR 1. addresses just a subset of the tutorials, and 2. may not be a viable solution (pending testing on the deploy preview).

Since this is affecting a project conf that I may not have historical knowledge as to why this wasn't used previously, I fully understand if we're not able to incorporate this one!

@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 38818c7
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/63f80a530ff7a800071e71ee
😎 Deploy Preview https://deploy-preview-2213--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kiersten-stokes
Copy link
Contributor Author

I have a question for someone more knowledgeable than me (@svekars 🙂). After building with make html, the notebook file created in the _build/html/_downloads directory looks like the below screenshot, with the image rendered as expected.

Screenshot 2023-02-21 at 5 40 51 PM

Is this the version notebook that would be available via the Run in Colab link once (hypothetically) the PR is merged?

@svekars
Copy link
Contributor

svekars commented Feb 24, 2023

Thanks, Kiersten. I'm not sure why we'd want this and what's the actual value. Can you please elaborate?

@kiersten-stokes
Copy link
Contributor Author

Can you please elaborate?

@svekars I should have included some screenshots in my description! Basically, while the built-in images are displayed in the HTML with no issue, they are not currently displayed in the notebook files.

Example of what is displayed in the Colab notebook now:

Screenshot 2023-02-24 at 10 25 09 AM

vs the HTML display:

Screenshot 2023-02-24 at 10 25 48 AM

These changes make it so that the the image is viewable in both the HTML and the notebook files (well, depending on the answer to the question I posed in this comment).

shown here in notebook form (though not in Colab obviously)

Screenshot 2023-02-24 at 10 29 20 AM

Definitely not a 'need-to-have' by any means but figured I would propose it since there was a corresponding issue!

@svekars
Copy link
Contributor

svekars commented Feb 24, 2023

Oh, I see. This definetely looks useful, although I'm not 100% sure if this would work. Let me check around and get back to you.

@kiersten-stokes
Copy link
Contributor Author

Oh, I see. This definetely looks useful, although I'm not 100% sure if this would work. Let me check around and get back to you.

@svekars any update? No hurry, just suddenly remembered that I had this one open 😄

@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale Stale PRs label Sep 26, 2024
@github-actions github-actions bot closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants