Fixes #3855#3867
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3867
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @jvz37! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Claude finished @sekyondaMeta's task in 3m 59s —— View job Review of PR #3867 vs Issue #3855 Requirements
Issue #3855 AlignmentBased on the PR description (which references issue #3855), the required fixes are:
All core requirements from the issue are addressed correctly. Code Review FindingsSubstantive changes (correct):
Minor issue — Sphinx Gallery formatting (non-blocking): At # module-level functions.
# ← line 518: blank (no #)
#
# There is another option for placing the result of a computation in anOn Additional changes (cosmetic): The PR includes a large number of whitespace and style changes (275 additions, 259 deletions across 2 files), but the vast majority are:
These are all harmless and pass lintrunner, but they do make the diff harder to review. Future PRs might benefit from separating functional fixes from style cleanup. CI StatusAll 5 CI checks pass: ✅ Lintrunner, ✅ Link check, ✅ Redirect check, ✅ Build tutorials, ✅ Build tutorials (nightly/test) SummaryThis PR correctly addresses all requirements from issue #3855. The deprecated |
Fixes #3855
Description
torch.sin_(b)withb.sin_()intensors_deeper_tutorial.pytorch.sin_(a)witha.sin_()inautogradyt_tutorial.pytorch.linalg.matmul()withtorch.matmul()intensors_deeper_tutorial.pytensors_deeper_tutorial.pyChecklist
cc @subramen