Skip to content

Update resnet.py#3522

Closed
shinji411 wants to merge 1 commit into
pytorch:masterfrom
shinji411:patch-1
Closed

Update resnet.py#3522
shinji411 wants to merge 1 commit into
pytorch:masterfrom
shinji411:patch-1

Conversation

@shinji411
Copy link
Copy Markdown

The original code "from .utils import load_state_dict_from_url" is not applicable.
you connot import load_state_dict_from_url from .utils.
change ".utils" to "torch.hub" can fix the problem.

The original code "from .utils import load_state_dict_from_url" is not applicable.
you connot import  load_state_dict_from_url from .utils.
change ".utils" to "torch.hub" can fix the problem.
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @shinji411!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2021

Codecov Report

Merging #3522 (cf97441) into master (c991db8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3522   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         105      105           
  Lines        9735     9735           
  Branches     1563     1563           
=======================================
  Hits         7662     7662           
  Misses       1582     1582           
  Partials      491      491           
Impacted Files Coverage Δ
torchvision/models/resnet.py 90.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c991db8...cf97441. Read the comment docs.

@datumbox
Copy link
Copy Markdown
Contributor

datumbox commented Mar 8, 2021

@shinji411 Sorry unfortunately we can't merge this one as it will break code on the FB side. The import at question is necessary to be imported as-is to enable FB-specific functionalities.

@datumbox datumbox closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants