Skip to content

Bugfix: Resnet AdaptiveAvgPool2d input change #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lsqshr wants to merge 1 commit into from
Closed

Bugfix: Resnet AdaptiveAvgPool2d input change #697

lsqshr wants to merge 1 commit into from

Conversation

@lsqshr
Copy link

@lsqshr lsqshr commented Dec 19, 2018

Simple fix to address #696

fmassa
fmassa requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change, but I think that it's only cosmetic, as I mentioned in #696

Can you double-check that by modifying it back still works?

@lsqshr lsqshr mentioned this pull request Jan 3, 2019
Closed
@fmassa
Copy link
Member

fmassa commented Jan 9, 2019

Closing according to the discussion in #696

@fmassa fmassa closed this Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lsqshr @fmassa