-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Restore the workflow to update vision repo viable/strict #9274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Huy Do <huydhn@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9274
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| with: | ||
| repository: pytorch/vision | ||
| stable-branch: viable/strict | ||
| requires: '[\"Build Linux\", \"Build M1\", \"Build Macos\", \"Build Windows\", \"Tests\", \"CMake\", \"Lint\", \"Docs\"]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just remove the macOS + Windows stuff here?
Is it really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let me tentatively make that change unless @NicolasHug wants to keep them. MacOS (x86) is dead and should be removed anyway, but Windows is still a thing from what I see in https://github.com/pytorch/vision/actions
Signed-off-by: Huy Do <huydhn@gmail.com>
NicolasHug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly updated the requires list - thank you so much for re-enabling this @huydhn !
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
Copy from https://github.com/pytorch/executorch/blob/main/.github/workflows/update-viablestrict.yml as used by ExecuTorch:
requireschecks from Remove viable strict workflow #8676. @NicolasHug Please double check that they are what vision needs to promoteviable/strict. All the signals there need to be green for the promotion to happen.update-viable-strictenv and populate with secrets for PyTorch update bot and ClickHouse.