Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Nov 17, 2025

Copy from https://github.com/pytorch/executorch/blob/main/.github/workflows/update-viablestrict.yml as used by ExecuTorch:

  • Update the list of requires checks from Remove viable strict workflow #8676. @NicolasHug Please double check that they are what vision needs to promote viable/strict. All the signals there need to be green for the promotion to happen.
  • Add a new update-viable-strict env and populate with secrets for PyTorch update bot and ClickHouse.

Signed-off-by: Huy Do <huydhn@gmail.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9274

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

with:
repository: pytorch/vision
stable-branch: viable/strict
requires: '[\"Build Linux\", \"Build M1\", \"Build Macos\", \"Build Windows\", \"Tests\", \"CMake\", \"Lint\", \"Docs\"]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove the macOS + Windows stuff here?

Is it really necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let me tentatively make that change unless @NicolasHug wants to keep them. MacOS (x86) is dead and should be removed anyway, but Windows is still a thing from what I see in https://github.com/pytorch/vision/actions

Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn requested a review from seemethere November 17, 2025 23:26
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly updated the requires list - thank you so much for re-enabling this @huydhn !

@NicolasHug NicolasHug merged commit 617079d into main Nov 18, 2025
37 of 44 checks passed
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug deleted the put-viablestrict-back branch November 18, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants