[ROCm] skip two gaussian_blur tests on gfx90a#9509
Conversation
Skip two gaussian_blur CUDA tests on AMD gfx90a (MI200, MI250) that fail due to small numerical differences with reference values. Other GPUs and CPU paths are unchanged. 1. `test_transforms_tensor.py::test_gaussian_blur[3-meth_kwargs4-cuda]` Failure: Batched GaussianBlur vs per-image calls disagree by 1 on a single uint8 pixel after rounding from fp32. Cause: MIOpen conv2d returns batch and single results that differ by 1 float32 ULP at a half-integer (batched: 188.50000000, single: 188.50001526), so rounding gives 188 vs 189. Not a transform logic bug. 2. `test_functional_tensor.py::test_gaussian_blur[gaussian_blur-sigma3-ksize2-dt3-large-cuda]` Failure: Output exceeds atol=1.0 vs stored OpenCV reference (max diff 1.125 at known pixels). Cause: Looks like incorrect fp16 OpenCV reference value. CPU (174.0) and gfx90a (173.875) both differ from OpenCV (175.0) but agree with each other within ~0.125 (1 fp16 ULP) Add gfx90a + ROCm + PYTEST_CURRENT_TEST guards to skip failed tests
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9509
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @dnikolaev-amd! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Hi @dnikolaev-amd , are these tests you can skip on your side in you own repo? There are dozens of thousands of tests in torchvision, having a per-test skipping logic for out-of-core repos isn't going to be tractable. |
|
Hi @NicolasHug, About the tests:
|
Summary
Skip two gaussian_blur CUDA tests on AMD gfx90a (MI200, MI250) that fail due to small numerical differences with reference values. Other GPUs and CPU paths are unchanged.
Refer this ROCM-19786 for more info.
Failures addressed
test_transforms_tensor.py::test_gaussian_blur[3-meth_kwargs4-cuda]Failure: Batched GaussianBlur vs per-image calls disagree by 1 on a single uint8 pixel after rounding from fp32.
Cause: MIOpen conv2d returns batch and single results that differ by 1 float32 ULP at a half-integer (batched: 188.50000000, single: 188.50001526), so rounding gives 188 vs 189. Not a transform logic bug.
test_functional_tensor.py::test_gaussian_blur[gaussian_blur-sigma3-ksize2-dt3-large-cuda]Failure: Output exceeds atol=1.0 vs stored OpenCV reference (max diff 1.125 at known pixels).
Cause: Looks like incorrect fp16 OpenCV reference value. CPU (174.0) and gfx90a (173.875) both differ from OpenCV (175.0) but agree with each other within ~0.125 (1 fp16 ULP)
Changes
Add gfx90a + ROCm + PYTEST_CURRENT_TEST guards to skip failed tests
cc @jeffdaily @jithunnair-amd