Skip to content

Conversation

Navifra-Kerry
Copy link

MSBuild Compile time casting Error

Kerry.cho added 2 commits May 22, 2019 23:29
  MSBuild Compile time casting Error
 MSBuild Error  static_cast<Long> to static_cast<int64_t>
@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #951 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
+ Coverage   60.15%   60.21%   +0.05%     
==========================================
  Files          63       63              
  Lines        5019     5019              
  Branches      748      748              
==========================================
+ Hits         3019     3022       +3     
+ Misses       1796     1794       -2     
+ Partials      204      203       -1
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 82.54% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249cfbf...ac4857d. Read the comment docs.

 Not Work find_contours
@peterjc123
Copy link
Contributor

cc @soumith @fmassa

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C++ / CUDA changes look good to me, but please remove the eval.py file in this PR, as it is unrelated to this fix.

But having a separate PR adding this feature would be something good to have, and I'm working on it as we speak

@@ -0,0 +1,139 @@
import numpy as np
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is completely unrelated to the windows build, right? I think it's a good idea to have it in the repo, but as a separate PR so that we can focus on how to better illustrate this.

@fmassa
Copy link
Member

fmassa commented May 23, 2019

I'll send a new PR removing the added file and fixing the lint for C++ in a few minutes. Thanks a lot for the fix on Windows!

@fmassa fmassa closed this May 23, 2019
@fmassa fmassa mentioned this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants