Removes several tests that were not properly tested on XLA #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I was thinking maybe we should add a |
Contributor
Author
That's a cool idea but I think we can provide a more robust alternative mechanism. Let's revisit next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were run as part of the origin test_torch review but they effectively generate subtests that would only run on the CPU or CUDA. This meant they were skipped on XLA (without reporting that they were skipped). This PR removes them so when they're enabled on XLA they won't break the CI.
pytorch/pytorch#26689 enabled two of them on XLA and broke the XLA CI, for example.