Adds support for TPU testing and tests test_indexing.py #1109
+76
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mruberry
commented
Sep 27, 2019
mruberry
commented
- XLA test device determined by xm.xla_device()
- sets PYTORCH_TEST_WITH_SLOW=1 to run all XLA tests in CI
- test_indexing added to tests with allowed tests in torch_test_meta.py
- failing tests commented out in same file
dlibenzi
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Thanks @mruberry !
This will make the tests run, but how do we deal with the tests that are going to fail due to accuracy?
Is there a way for that tunable to be fed on a per tests basis?
We could disable the tests but I feel we lose important signal if we do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.