Add test_bool_sub to allowed tests. #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlibenzi
requested changes
Sep 30, 2019
torch_xla/csrc/aten_xla_type.cpp
Outdated
| return tensor_type == type; | ||
| } | ||
|
|
||
| void sub_check(const at::Tensor& self, const at::Tensor& other) { |
torch_xla/csrc/aten_xla_type.cpp
Outdated
| at::Scalar alpha) { | ||
| return bridge::AtenFromXlaTensor( | ||
| XLATensor::rsub(bridge::GetXlaTensor(self), other, alpha)); | ||
| return rsub(self, c10::scalar_to_tensor(other, self.device()), alpha); |
Collaborator
There was a problem hiding this comment.
Do not route this to the previous rsub().
We have special logic to convert scalars to tensors.
Same thing below.
ailzhang
force-pushed
the
fix_bool_sub
branch
4 times, most recently
from
6cbc115 to
a59a14e
Compare
dlibenzi
reviewed
Sep 30, 2019
torch_xla/csrc/torch_util.cpp
Outdated
| } else if (scalar.isComplex()) { | ||
| return at::kComplexDouble; | ||
| } else { | ||
| TORCH_CHECK(scalar.isIntegral(/*includeBool=*/false)); |
Collaborator
There was a problem hiding this comment.
I'd use:
XLA_CHECK(scalar.isIntegral(/*includeBool=*/false));
Maybe you can even pipe the scalar in there:
XLA_CHECK(scalar.isIntegral(/*includeBool=*/false)) << scalar;
Collaborator
There was a problem hiding this comment.
We use XLA_CHECK*() in our code 😉
ailzhang
force-pushed
the
fix_bool_sub
branch
from
a59a14e to
3e7cdb3
Compare
dlibenzi
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.