Skip to content

Conversation

@jysohn23
Copy link
Collaborator

@jysohn23 jysohn23 commented Oct 9, 2019

No description provided.

@jysohn23 jysohn23 requested review from ailzhang and dlibenzi October 9, 2019 04:53
@jysohn23 jysohn23 requested a review from dlibenzi October 9, 2019 18:40
@jysohn23 jysohn23 force-pushed the cloud-tutorials branch 2 times, most recently from 9e6f24a to 0f30081 Compare October 9, 2019 18:57
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

@dlibenzi
Copy link
Collaborator

You likely need to rebase to pull ahead of @ailzhang PR which fixed the numel() override.

@jysohn23 jysohn23 merged commit 1ef5dfc into master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants