Make inplace operations and view cooperate with each other. #157
Conversation
dlibenzi
force-pushed
the
tensor_alias
branch
from
f609cc2 to
6918efa
Compare
|
Hold on on this one. I am waiting that you do the C++ test restructuring to add tests. |
asuhan
left a comment
asuhan
left a comment
There was a problem hiding this comment.
This looks pretty good, but it needs tests.
- Basic functionality:
v = x.view(...), thenx.add_(b)andv = x.view(...), thenv.add_(b). In both casesxshould be updated. - View-of-view cases.
- Some more complex expressions involving view would be reassuring.
torch_xla/csrc/tensor.cpp
Outdated
| return id_generator->fetch_add(1); | ||
| } | ||
|
|
||
| std::pair<ir::NodePtr, bool> XLATensor::GetViewIrNode(View* view) { |
There was a problem hiding this comment.
I would use a structure here instead of a pair.
|
It's not much restructuring at all, you should be able to rebase just fine. But I'm sending the PR right now. |
dlibenzi
force-pushed
the
tensor_alias
branch
from
1cec8cf to
d42a3f3
Compare
|
Test added. Will add more complex tests later on. |
asuhan
left a comment
asuhan
left a comment
There was a problem hiding this comment.
Do you mind adding a Python version of the tests as well?
|
Why should we add the Python versions? |
|
We don't have to, we can move forward with just C++ tests. But we have to decide what should go in the Python tests then and how to deal with the debug mode not working for the C++ tests. |
2 participants
No description provided.