Skip to content

Extend scalar type creation to FP16. #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2020
Merged

Extend scalar type creation to FP16. #1942

merged 1 commit into from
Apr 21, 2020

Conversation

@dlibenzi
Copy link
Collaborator

@dlibenzi dlibenzi commented Apr 20, 2020

No description provided.

@dlibenzi dlibenzi requested review from JackCaoG and ailzhang April 20, 2020 23:31
ailzhang
ailzhang approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

JackCaoG
JackCaoG approved these changes Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlibenzi dlibenzi merged commit 3cdcf81 into master Apr 21, 2020
@dlibenzi dlibenzi deleted the half_scalar branch April 21, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

+1 more reviewer

@ailzhang ailzhang ailzhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlibenzi @ailzhang @JackCaoG