Skip to content

Added cast operations. #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2019
Merged

Added cast operations. #283

merged 1 commit into from
Feb 16, 2019

Conversation

@dlibenzi
Copy link
Collaborator

@dlibenzi dlibenzi commented Feb 16, 2019

No description provided.

@dlibenzi dlibenzi requested a review from asuhan February 16, 2019 03:09
asuhan
asuhan reviewed Feb 16, 2019
View reviewed changes
Copy link
Contributor

@asuhan asuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be tested on TPU. I think we'll need to do the U8 -> S32 mapping first to make this work. It's ok to land this for CPU only.

@dlibenzi
Copy link
Collaborator Author

dlibenzi commented Feb 16, 2019

Same issue as kConvert of S64->PRED we have on Where(). Will go in with this, and fix for both.

@dlibenzi dlibenzi merged commit 7356cde into master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@asuhan asuhan asuhan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dlibenzi @asuhan