Skip to content

1.8.1: add procps #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

1.8.1: add procps #2888

merged 1 commit into from
Apr 15, 2021

Conversation

@zcain117
Copy link
Collaborator

@zcain117 zcain117 commented Apr 15, 2021

Needed for 1.8.1 tests

@zcain117 zcain117 requested a review from JackCaoG April 15, 2021 23:45
JackCaoG
JackCaoG approved these changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JackCaoG
Copy link
Collaborator

JackCaoG commented Apr 15, 2021

Maybe we should cherrypick #2887 too? So torch_xla won't error out even if pgrep is not installed.

@zcain117 zcain117 merged commit 3bca2d7 into r1.8.1 Apr 15, 2021
@zcain117 zcain117 deleted the r1-8-1-procps branch April 15, 2021 23:49
@zcain117
Copy link
Collaborator Author

zcain117 commented Apr 15, 2021

Sure, I can work on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcain117 @JackCaoG