Enable the conversion API to work across allowed types. #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlibenzi
force-pushed
the
multi_convert
branch
from
7b10302 to
79e7bb1
Compare
asuhan
suggested changes
Feb 18, 2019
test/cpp/test_tensor.cpp
Outdated
| namespace cpp_test { | ||
| namespace { | ||
|
|
||
| bool IsBidirectionalConversion( |
Contributor
There was a problem hiding this comment.
This name is confusing, I'd rather have a name which reflects that it's a test helper. How about CheckBidirectionalConversion?
dlibenzi
force-pushed
the
multi_convert
branch
from
79e7bb1 to
f32c5f2
Compare
asuhan
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.