Skip to content

Conversation

@JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Nov 2, 2021

This is to fix #3192. Need to backport to 1.10 but silu_backward symbol is missing on pytorch 1.10.

Pytorch pr to add symbol pytorch/pytorch#67665

@JackCaoG JackCaoG added lowering ATen Operation lowering REMOVE_TORCH_PIN labels Nov 2, 2021
Copy link
Collaborator

@miladm miladm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @JackCaoG

@JackCaoG JackCaoG mentioned this pull request Nov 6, 2021
@JackCaoG JackCaoG merged commit 73a3937 into master Nov 17, 2021
@JackCaoG JackCaoG deleted the silu_backward branch November 17, 2021 19:06
ysiraichi added a commit that referenced this pull request May 22, 2025
- `SgnOp` and `SignOp`
    - Full codegen migration: #3577
    - Mistakenly re-introduced: #3572
- `LogSigmoid`
    - Introduced: #3539
    - Full codegen migration: #3743
- `SiLU`
    - Introduced: #2721
    - Full codegen migration: #3780
- `SiLUBackward`
    - Introduced: #3195
    - Full codegen migration: #3780
- `SeLU`
    - Introduced: #3547
    - Full codegen migration: #3780
- `Sigmoid`
    - Introduced: 6a73deb (no PR record)
    - Full codegen migration: #6342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lowering ATen Operation lowering REMOVE_TORCH_PIN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

silu lowering regression in 1.10

3 participants