Use update-alternatives to link clang++ -> clang++-8
#3363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeounoh
reviewed
Feb 10, 2022
| sudo apt-get install -y clang-8 clang++-8 | ||
| maybe_append 'export CC=clang-8 CXX=clang++-8' ~/.bashrc | ||
| export CC=clang-8 CXX=clang++-8 | ||
| sudo update-alternatives --install /usr/bin/clang++ clang++ $(which clang++-8) 70 |
There was a problem hiding this comment.
Ugh, what happens if this image is used in the upstream, and PyTorch build uses a different clang version? If they try ln -s it will break.
There was a problem hiding this comment.
ehh, right. I think we need to add a check whether clang++ existed or not. I will revert this change as it will likely break pytorch upstream.
There was a problem hiding this comment.
@JackCaoG @will-cromar sorry about the confusion, this is infra image, not circleci image
JackCaoG
pushed a commit
that referenced
this pull request
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the currently broken Docker build.
Ran docker build locally to checkout output of
update-alternatives: