Migrate to upstream OpKind #3398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@wonjoolee95 Could you add a more detail description? Like which class you are migrating to, what's the difference between existing class and upstream etc |
Collaborator
Author
@JackCaoG Sure thing, meant to update it earlier this morning. This is more of an attempt to make the original PR #3385 smaller. Added in some info to the PR summary on top. |
JackCaoG
approved these changes
Mar 1, 2022
Collaborator
JackCaoG
left a comment
JackCaoG
left a comment
There was a problem hiding this comment.
Thanks! Could you fix the conflict?
Collaborator
Author
|
Fixed some merge conflicts. Will merge as CI tests pass. |
wonjoo-wj
force-pushed
the
lazy-tensor-opkind
branch
from
4df8777 to
cdd2631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates existing
torch_xla::ir::OpKindtotorch::lazy::OpKind, which is required to migrateNode,Value, andOutputclasses. This PR only does simple replacement (no inheritance, logic change, etc), since the existingtorch_xla::ir::OpKindand the upstreamtorch:lazy::OpKindare the same. This PR replaces all the calls and initializations totorch::lazy::OpKind.Initially was part of #3385, separated into the new PR to make the original PR bit smaller and easier to review.