Skip to content

Allow boolean scalar value #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JackCaoG merged 1 commit into from
Mar 22, 2022
Merged

Allow boolean scalar value #3436

JackCaoG merged 1 commit into from
Mar 22, 2022

Conversation

@JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Mar 22, 2022

This should fix our w2v2 turorial, which currently failed at

Exception in device=TPU:2: /home/jackcao/pytorch/xla/torch_xla/csrc/helpers.h:105 : Check failed: scalar_value.isIntegral()

@JackCaoG JackCaoG requested a review from miladm March 22, 2022 04:08
@miladm
Copy link
Collaborator

miladm commented Mar 22, 2022

Thanks @JackCaoG!
Can you point to the source of recompilations you mentioned offline?

@JackCaoG
Copy link
Collaborator Author

JackCaoG commented Mar 22, 2022

@miladm I think those are expected in the first few epochs as warning message suggested.

miladm
miladm approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@miladm miladm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JackCaoG
LGTM

@JackCaoG JackCaoG merged commit 3d852eb into master Mar 22, 2022
@JackCaoG JackCaoG deleted the fix_w2v2 branch March 22, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miladm miladm miladm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackCaoG @miladm