Made autogen handle cases similar to copy(), where a different "refer… #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence param" needs to be picked for device parameter.
dlibenzi
force-pushed
the
copylike_gen
branch
from
71d218e to
eceb8d8
Compare
asuhan
suggested changes
Feb 26, 2019
Contributor
asuhan
left a comment
asuhan
left a comment
There was a problem hiding this comment.
Why not use it for copy() then?
Collaborator
Author
We can avoid going to CPU type for copy call, in that case. |
Contributor
|
I see. It's just an additional virtual dispatch, right? What am I missing? |
Collaborator
Author
We have already made a copy ourselves ... going down the path will create a new one. |
asuhan
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ence param" needs to be picked for device parameter.