Use at::rand for GetTestTensor, remove GetTestTensor #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For formatting I used to resolve formatting issues. |
dlibenzi
reviewed
Mar 3, 2019
Collaborator
dlibenzi
left a comment
dlibenzi
left a comment
There was a problem hiding this comment.
I noticed the inconsistency yesterday, but honestly, GetTestTensor() really does nothing special (not even setting the XLA device).
It first born with the idea of setting the XLA device, but the new design has ForEachDevice(), so that's just an empty shell.
I'd eventually go the other way around, as here we are already doing a bunch of at:: API calls, and we can be explicit about at::rand() as well.
Contributor
Author
|
That sounds reasonable, I'll revert the changes and remove |
vishwakftw
changed the title
Contributor
Author
|
The below command returns nothing to stdout: clang-format -style=Google test_aten_xla_tensor.cpp | diff test_aten_xla_tensor.cpp -I believe the file is formatted as required. |
dlibenzi
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
sed -i 's/at::rand(\({.*}\), at::TensorOptions(at::kFloat))/GetTestTensor(\1)/g' test_aten_xla_tensor.cpp