Add lowring for floor_divide #3923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
approved these changes
Aug 24, 2022
Collaborator
JackCaoG
left a comment
JackCaoG
left a comment
There was a problem hiding this comment.
It is one of those ops that will be deprecated but I guess we need to lower it for the time being.
Collaborator
|
seems like op test is failing, this test used to always fallback to CPU or passed. after this pr floor_divide will be run on xla device and had some mismatch behavior compared to pytorch one. |
Contributor
Author
|
Ok, I see what's wrong here. The pytorch doc I checked (1.12 stable release) is outdated and pytorch master has changed the rounding mode from "trunc" to "floor". I've fixed this issue and updated the C++ tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This op is seen in DETR model. https://pytorch.org/docs/stable/generated/torch.floor_divide.html.