Skip to content

enable nn/convolution tests #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2022
Merged

enable nn/convolution tests #4120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
052054a
enable nn/convolution tests
kshitij12345 Oct 25, 2022
8c67541
update run_tests.sh
kshitij12345 Oct 25, 2022
d46cb40
Merge branch 'pytorch:master' into nn/split/convolutions
kshitij12345 Oct 26, 2022
d037e69
Merge branch 'pytorch:master' into nn/split/convolutions
kshitij12345 Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/pytorch_test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,8 @@
'test_silu_inplace_overlap_xla', # doesn't raise
'test_softplus_inplace_overlap_xla', # doesn't raise
'test_softshrink_inplace_overlap_xla', # doesn't raise
'test_Conv2d_backward_depthwise_xla_float64', # slow compilation
'test_leaky_relu_inplace_with_neg_slope_xla', # expecting a specific error message
'test_upsamplingBicubic2d_correctness_xla', # FIXME! Got dtypes torch.float32 and torch.float64
'test_conv3d_same_padding_backward_xla', # XLA tensors do not have storage,
'test_CTCLoss_no_batch_dim_xla', # Value out of range
'test_upsamplingBilinear2d_xla', # precision on GPU/TPU, slow compilation on CPU
},
Expand All @@ -286,6 +284,12 @@
'test_EmbeddingBag_per_sample_weights_and_no_offsets', # FIXME! Unsupported device type for sparse layout: xla
},

# test/nn/test_convolution.py
'TestConvolutionNNDeviceTypeXLA': {
'test_Conv2d_backward_depthwise_xla_float64', # slow compilation
'test_conv3d_same_padding_backward_xla', # XLA tensors do not have storage
},

# test_type_promotion.py
'TestTypePromotionXLA': {
'test_many_promotions', # stride
Expand Down
1 change: 1 addition & 0 deletions test/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ function run_op_tests {
run_dynamic python3 "$CDIR/../../test/nn/test_dropout.py" "$@" -v TestDropoutNNDeviceTypeXLA
run_dynamic python3 "$CDIR/../../test/nn/test_pooling.py" "$@" -v TestPoolingNNDeviceTypeXLA
run_dynamic python3 "$CDIR/../../test/nn/test_embedding.py" "$@" -v TestEmbeddingNNDeviceTypeXLA
run_dynamic python3 "$CDIR/../../test/nn/test_convolution.py" "$@" -v TestConvolutionNNDeviceTypeXLA
run_dynamic python3 "$CDIR/../../test/test_type_promotion.py" "$@" -v TestTypePromotionXLA
run_dynamic python3 "$CDIR/test_operations.py" "$@" --verbosity=$VERBOSITY
run_opbyop python3 "$CDIR/test_operations.py" "$@" --verbosity=$VERBOSITY
Expand Down