Bump relative and absolute tolerance for TestSymEig#428
Merged
Conversation
Required to pass on TPU.
dlibenzi
reviewed
Mar 10, 2019
Collaborator
dlibenzi
left a comment
dlibenzi
left a comment
There was a problem hiding this comment.
Hmm, I ran it 4 or 5 times (the run_tests.sh) and they passed for me.
Tolerances seems a bit high there.
Did you run on TPU v2 or TPU v3?
Contributor
Author
|
Ran it on TPU v3. The values looked ok to me, differences weren't unreasonable for what this is. |
dlibenzi
approved these changes
Mar 10, 2019
Collaborator
dlibenzi
left a comment
dlibenzi
left a comment
There was a problem hiding this comment.
I ran on v2. Let's go with it, but 3e-2 seems a bit high to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to pass on TPU.