-
Notifications
You must be signed in to change notification settings - Fork 559
Add a test case for BuildInputOutputAliases #4329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is still a WIP as I'm puzzled on the way how we trigger |
|
@alanwaketan do you still plan to merge this pr? |
Can we talk more about this tomorrow? I have some questions. |
|
Let me actually play with your code a bit, the way that |
Sounds good. Feel free to develop on the branch. |
|
Ah I know what's going on, by you created an intermediate tensor with new tensor ID and assign it back to t2, if you do the alias count incremented as expected |
|
Let me rebase and add some comments to the code |
This is tricky. Thanks for the investigation! |
04daadd to
f6ea706
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit weird, but I am going to approve my own change lol
f6ea706 to
b453444
Compare
|
I guess we can land this now, and later I can add more test cases for views. Thanks for helping this, Jack. |
|
@alanwaketan yea I will merge this once all test passed. |
b453444 to
c0f8d63
Compare
Summary:
This patch tries to add a test case for
BuildInputOutputAliasesand fixes the corresponding metric which reports a bogus value that's the total number of outputs.Test Plan:
PJRT_DEVICE=CPU python test/test_input_output_aliases.py