Add test to verify virtual device usage metrics #4330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeounoh
reviewed
Dec 14, 2022
| device=xm.xla_device()) | ||
| xs.mark_sharding(xt1, self._get_mesh((1, self.n_devices)), partition_spec) | ||
| self.assertIn("VirtualDeviceUsage", met.counter_names()) | ||
| self.assertNotEqual(met.counter_value("VirtualDeviceUsage"), 0) |
There was a problem hiding this comment.
This looks good to me. Could we add another test case showing that the model param sharding doesn't use virtual device?
There was a problem hiding this comment.
Added a test for sharding on model weights. It looks like virtual device will still be used to delay the transfer of the model weights in nn.Linear(128, 64).to(xm.xla_device()) until the sharding is applied.
yeounoh
suggested changes
Dec 14, 2022
steventk-g
force-pushed
the
virtual-device-metrics-test
branch
2 times, most recently
from
eb0f306 to
69d829d
Compare
steventk-g
force-pushed
the
virtual-device-metrics-test
branch
from
69d829d to
ac36708
Compare
JackCaoG
approved these changes
Dec 15, 2022
steventk-g
force-pushed
the
virtual-device-metrics-test
branch
from
ac36708 to
3f17c4a
Compare
steventk-g
added a commit
that referenced
this pull request
Dec 15, 2022
#4331) * Add test to verify virtual device usage metrics (#4330) * Add test to verify that virtual device reduces outbound data size for SPMD * Update env var manipulation for outbound data test * Revert "Update env var manipulation for outbound data test" This reverts commit 15d986a. * Unwrap metric
This was referenced Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.