Skip to content

Temporarily remove MKL related tests #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2022
Merged

Temporarily remove MKL related tests #4345

merged 3 commits into from
Dec 16, 2022

Conversation

@steventk-g
Copy link
Collaborator

@steventk-g steventk-g commented Dec 16, 2022

No description provided.

yeounoh
yeounoh approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@yeounoh yeounoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, approving to temporarily disable the failing tests until we fix the MKL issue.

@JackCaoG
Copy link
Collaborator

JackCaoG commented Dec 16, 2022

rebase should get build to work again. However I think more cpp test will failed, script exicted because it segfaulted. we might need to disable the cpptest alltogether.

@JackCaoG
Copy link
Collaborator

JackCaoG commented Dec 16, 2022

Let's rebase and commented out

xla/.circleci/common.sh

Lines 150 to 157 in 4c7c343

pushd test/cpp
echo "Running C++ Tests"
./run_tests.sh
if ! [ -x "$(command -v nvidia-smi)" ]
then
./run_tests.sh -X early_sync -F AtenXlaTensorTest.TestEarlySyncLiveTensors -L""
fi

@steventk-g steventk-g marked this pull request as ready for review December 16, 2022 02:22
JackCaoG
JackCaoG reviewed Dec 16, 2022
View reviewed changes
test/cpp/test_aten_xla_tensor.cpp
});
}

TEST_F(AtenXlaTensorTest, TestSVD) {
Copy link
Collaborator

@JackCaoG JackCaoG Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we revert these changes since we disabled all cpp tests?

@JackCaoG JackCaoG merged commit 09a6e7f into master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

+1 more reviewer

@yeounoh yeounoh yeounoh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steventk-g @JackCaoG @yeounoh