Skip to content

Conversation

@will-cromar
Copy link
Collaborator

@will-cromar will-cromar commented Dec 21, 2022

  • Make schedule configurable and optional
  • Add build_on_push option for unscheduled builds
  • Put scheduler service account in Terraform config
  • Add a worker pool with more resources to Terraform and GCB yaml
  • Fix some bugs with applying torch patches and pins
  • Remove Kaniko caching and replace with docker build. Kaniko was producing and caching invalid images (known issue). We can revisit image caching later.

The hackery I use with for_each and count in Terraform are apparently the normal way to apply resources conditionally.

Test build with patched r1.13 branch passed:
image

@will-cromar will-cromar force-pushed the wcromar/terraform-release branch from 37a02ac to 7b8d9ee Compare January 3, 2023 18:40
@will-cromar will-cromar merged commit f7678c0 into master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants