Skip to content

Initialize logical_element_type before sharding in XLATensor::Data #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yeounoh merged 1 commit into from
Jan 5, 2023
Merged

Initialize logical_element_type before sharding in XLATensor::Data #4418

yeounoh merged 1 commit into from
Jan 5, 2023

Conversation

@yeounoh
Copy link
Contributor

@yeounoh yeounoh commented Jan 5, 2023

Fixes

Step #0: /pytorch/xla/torch_xla/csrc/tensor.h:86:11: warning: field 'logical_element_type' will be initialized after field 'sharding' [-Wreorder]
Step #0:           logical_element_type(logical_element_type),
Step #0:           ^

warning.

@yeounoh yeounoh added tech debt Technical Debt Is Evil distributed SPMD and other distributed things. labels Jan 5, 2023
@yeounoh yeounoh self-assigned this Jan 5, 2023
alanwaketan
alanwaketan approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yeounoh
Copy link
Contributor Author

yeounoh commented Jan 5, 2023

Will land this after the build & confirming the warning is no more.

@yeounoh
Copy link
Contributor Author

yeounoh commented Jan 5, 2023

Build completed without the warning in question log. Landing.

@yeounoh yeounoh merged commit 8b8d289 into master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanwaketan alanwaketan alanwaketan approved these changes

@JackCaoG JackCaoG JackCaoG approved these changes

Assignees

@yeounoh yeounoh

Labels

distributed SPMD and other distributed things. tech debt Technical Debt Is Evil

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yeounoh @alanwaketan @JackCaoG