Skip to content

Update CONTINUE_ON_ERROR if statement in CircleCI bash scripts #4419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Update CONTINUE_ON_ERROR if statement in CircleCI bash scripts #4419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -ex

# See Note [Keep Going]
CONTINUE_ON_ERROR=false
if [[ "$CONTINUE_ON_ERROR" != "1" ]]; then
if [[ "$CONTINUE_ON_ERROR" == "1" ]]; then
set +e
fi

Expand Down
2 changes: 1 addition & 1 deletion test/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ VERBOSITY=2
# This flag should be set to `false`` by default. After testing your changes, make sure
# to set this flag back to `false`` before you merge your PR.
CONTINUE_ON_ERROR=false
if [[ "$CONTINUE_ON_ERROR" != "1" ]]; then
if [[ "$CONTINUE_ON_ERROR" == "1" ]]; then
set +e
fi

Expand Down