Skip to content

[LTC] XlaBackendImpl::SetRngSeed is not used #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanwaketan merged 2 commits into from
Jan 9, 2023
Merged

[LTC] XlaBackendImpl::SetRngSeed is not used #4421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4890869
Log error on SetRngSeed
alanwaketan Jan 5, 2023
1fd68b8
Fix linters
alanwaketan Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions torch_xla/csrc/xla_backend_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ class XlaBackendImpl : public torch::lazy::BackendImplInterface {
void PrepareToExit() const override { XLA_ERROR() << "Not implemented yet"; }

void SetRngSeed(size_t seed) const override {
// TODO(JackCaoG): upstream SetRngSeed should either be removed or start
// taking device.
// XLATensor::SetRngSeed(device, seed);
// TODO(alanwaketan): This interface is not useful. We probably should
// remove the base one.
XLA_ERROR() << "Not implemented yet";
return;
}

Expand Down