Switch to pytorch sccache #4489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yeounoh Can you take this one? |
|
@huydhn will verify, thank you! |
yeounoh
reviewed
Jan 26, 2023
| # if image layers are not present in the repo. | ||
| docker tag ${GCR_DOCKER_IMAGE} ${ECR_DOCKER_IMAGE_BASE}:v0.6 >/dev/null | ||
| docker push ${ECR_DOCKER_IMAGE_BASE}:v0.6 >/dev/null | ||
| docker tag ${GCR_DOCKER_IMAGE} ${ECR_DOCKER_IMAGE_BASE}:v0.7 >/dev/null |
There was a problem hiding this comment.
Could we use v0.8? v0.7 was already taken, so I pushed under v0.8 while testing/verifying your image in our CI.
There was a problem hiding this comment.
Actually, I can merge and bump up the version separately.
|
Oh, I think we also need to rebase before merging 🙏 looking at the test failures. |
|
@yeounoh Thank you for doing the rebase for me. I'll update XLA docker image on PyTorch CI to v0.8 accordingly |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 26, 2023
Given the context in pytorch/xla#4489, we now have a new XLA Docker image `v0.8`. This should fix the flaky sccache initialization failures with XLA. Pull Request resolved: #93041 Approved by: https://github.com/malfet
ManfeiBai
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Use pytorch/sccache * Up the image version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, there are some flaky sccache start-up failures on PyTorch when building XLA, for example:
The full list can be found here. The error, strangely, comes only from XLA.
It turns out that XLA
pytorch/xla_base:v0.6uses upstream sccache fromhttps://github.com/mozilla/sccache.gitwhile the rest of PyTorch CI uses a custom fork fromhttps://github.com/pytorch/sccache.gitas defined in https://github.com/pytorch/pytorch/blob/master/.circleci/docker/common/install_cache.sh#L12IMO, it's easier to stick to
https://github.com/pytorch/sccache.gitas the rest of the CI till we have the capacity to do the switch back to upstream sccache.AFAIK,
https://github.com/pytorch/sccache.githas some fixes to work with nvcc.