Skip to content

Switch to pytorch sccache #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Switch to pytorch sccache #4489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f896be7
Use pytorch/sccache
huydhn Jan 21, 2023
50a3035
Up the image version
huydhn Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ launch_docker_and_build: &launch_docker_and_build
# To allow the upstream workflow to access PyTorch/XLA build images, we
# need to have them in the ECR. This is not expensive, and only pushes it
# if image layers are not present in the repo.
docker tag ${GCR_DOCKER_IMAGE} ${ECR_DOCKER_IMAGE_BASE}:v0.6 >/dev/null
docker push ${ECR_DOCKER_IMAGE_BASE}:v0.6 >/dev/null
docker tag ${GCR_DOCKER_IMAGE} ${ECR_DOCKER_IMAGE_BASE}:v0.7 >/dev/null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use v0.8? v0.7 was already taken, so I pushed under v0.8 while testing/verifying your image in our CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I can merge and bump up the version separately.

docker push ${ECR_DOCKER_IMAGE_BASE}:v0.7 >/dev/null
sudo pkill -SIGHUP dockerd
# To enable remote caching, use SCCACHE_BUCKET=${SCCACHE_BUCKET}
# To disable remote caching, use SCCACHE_BUCKET=${LOCAL_BUCKET}
Expand Down
2 changes: 1 addition & 1 deletion .circleci/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ ENV RUSTUP_HOME /opt/rustup

RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
RUN . $CARGO_HOME/env && \
git clone --recursive https://github.com/mozilla/sccache.git && \
git clone --recursive https://github.com/pytorch/sccache.git && \
cd sccache && \
cargo install sccache && \
cd .. && \
Expand Down