Skip to content

Fix fp64 div issue #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Fix fp64 div issue #4595

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9b9843
Add test for div by f64 bug
ymwangg Feb 9, 2023
29a8a32
Add torch_pin
ymwangg Feb 9, 2023
613fc5f
Delete .torch_pin
JackCaoG Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/test_operations_hlo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ def test_special_scalars_addcdiv_addcmul(self):
assert 'f32' in root_hlo
assert 'f64' not in root_hlo

def test_div_by_f64(self):
mod = torch.nn.MultiheadAttention(768, 12, batch_first=True)
mod.to(xm.xla_device())
a = torch.rand(1, 512, 768).to(xm.xla_device())
b, _ = mod(a, a, a, need_weights=False)
b.sum().backward()
hlo_text = torch_xla._XLAC._get_xla_tensors_text(
[p.grad for p in mod.parameters() if p.requires_grad])
assert 'f64' not in hlo_text


if __name__ == '__main__':
torch.set_default_tensor_type('torch.FloatTensor')
Expand Down