Skip to content

[Functionalization] Properly skip test_empty_strided #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2023
+3 −1
Merged

[Functionalization] Properly skip test_empty_strided #4609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00f28b8
[Functionalization] Properly skip test_empty_strided
alanwaketan Feb 10, 2023
90d186a
fix linters
alanwaketan Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/test_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,9 @@ def test_empty_advanced_indexing(self):
xla_result = xla_base[:, torch.empty(0, 6, dtype=torch.int64)]
self.assertEqual(result, xla_result)

@unittest.skip("Produce wrong results on grad_input")
@unittest.skip(
"grad_input produces wrong results after functionalization. pytorch/pytorch#91199"
)
def test_empty_strided(self):
xla_device = xm.xla_device()
m = nn.Conv1d(4, 6, kernel_size=3, groups=2)
Expand Down