Skip to content

[PJRT] Remove start method from _run_singleprocess #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

[PJRT] Remove start method from _run_singleprocess #4709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions test/pjrt/test_experimental_pjrt_tpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,7 @@ def _assert(i):

xmp.spawn(_assert, nprocs=1)

@absltest.skipIf(
tpu.version() <= 2,
'This test is not currently supported on v2 TPUVMs or earlier.')
def test_xla_devices_single_process_one_chip_one_device_spawn(self):
accelerators = ['v3-8', 'v4-8']

if self.accelerator_type not in accelerators:
raise NotImplementedError('Test not implemented for {}'.format(
self.accelerator_type))

# Avoid initializing the TPU client in the parent process
with concurrent.futures.ProcessPoolExecutor(max_workers=1) as executor:
executor.submit(self._fail_on_nonfirst_device).result()
Expand Down Expand Up @@ -194,9 +185,6 @@ def _spawn_threads() -> Dict[int, torch.device]:

return results

@absltest.skipIf(
tpu.version() <= 2,
'This test is not currently supported on v2 TPUVMs or earlier.')
def test_spawn_threads(self):
with concurrent.futures.ProcessPoolExecutor(max_workers=1) as e:
results = e.submit(self._spawn_threads).result()
Expand Down
4 changes: 1 addition & 3 deletions torch_xla/experimental/pjrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,6 @@ def _run_singleprocess(fn: Callable[..., R], *args, **kwargs) -> Dict[int, R]:
Args:
fn: Function to run on the device devices
args: args to pass to `fn`
start_method: The Python `multiprocessing` process creation method.
Default: `spawn`
kwargs: kwargs to pass to `fn`

Returns:
Expand Down Expand Up @@ -360,7 +358,7 @@ def spawn(fn: Callable,
spawn_fn = _SpawnFn(fn, *args)

if nprocs == 1:
return _run_singleprocess(spawn_fn, start_method=start_method)
return _run_singleprocess(spawn_fn)
elif nprocs is not None:
logging.warning('Unsupported nprocs (%d), ignoring...' % nprocs)

Expand Down