Skip to content

Conversation

@wonjoo-wj
Copy link
Collaborator

@wonjoo-wj wonjoo-wj commented Apr 15, 2023

Lower view_as_complex_copy and view_as_real_copy

Test plan:

  • xla/test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestViewAsComplexCopy
  • xla/test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestViewAsRealCopy
  • python test/test_ops.py

view_as_complex_copy: https://pytorch.org/docs/stable/generated/torch.view_as_complex.html
view_as_real_copy: https://pytorch.org/docs/stable/generated/torch.view_as_real.html

@wonjoo-wj wonjoo-wj marked this pull request as ready for review April 17, 2023 09:15
@cowanmeg cowanmeg self-requested a review April 17, 2023 17:46
Copy link
Collaborator

@cowanmeg cowanmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wonjoo-wj
Copy link
Collaborator Author

Thanks, Meghan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants