Backport infra/ansible to r1.12 #5341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
requested review from
JackCaoG,
mateuszlewko,
stgpetrovic and
will-cromar
as code owners
Collaborator
Author
|
Pending work: update tag to the latest commit. |
wonjoo-wj
approved these changes
Jul 25, 2023
Collaborator
Author
|
it looks like we don't want to touch the r1.12 branch and don't need more wheels hence closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to what we did to r2.0 in #5104 for the similar reason.
The reason why we need to do this is: I need to revert this PR #5106 so that terraform/ansible can pick up my change on branch r2.0. Without doing this, the 1.12 build will fail because it cannot find ansible on r1.12 branch.