Skip to content

Add bundled libtpu build for Python 3.10 #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2023
+10 −1
Merged

Add bundled libtpu build for Python 3.10 #5564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dd6931
Add bundled libtpu build for Python 3.10
will-cromar Sep 13, 2023
8b0db4d
make bundle explicit
will-cromar Sep 13, 2023
b753640
sanitize package version
will-cromar Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions infra/tpu-pytorch-releases/artifacts.auto.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ versioned_builds = [
pytorch_git_rev = "v2.1.0-rc2"
package_version = "2.1.0rc2"
accelerator = "tpu"
bundle_libtpu = "0"
},
{
git_tag = "v2.1.0"
Expand All @@ -54,6 +55,14 @@ versioned_builds = [
python_version = "3.10"
bundle_libtpu = "0"
},
{
git_tag = "v2.1.0"
pytorch_git_rev = "v2.1.0-rc2"
package_version = "2.1.0rc2+libtpu"
accelerator = "tpu"
python_version = "3.10"
bundle_libtpu = "1"
},
{
git_tag = "v2.0.0"
package_version = "2.0"
Expand Down
2 changes: 1 addition & 1 deletion infra/tpu-pytorch-releases/artifacts_builds.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ locals {
versioned_builds_dict = {
for b in var.versioned_builds :
format("r%s_%s_%s",
b.package_version,
replace(b.package_version, "+", "_"),
Copy link
Collaborator

@JackCaoG JackCaoG Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this line do?

Copy link
Collaborator Author

@will-cromar will-cromar Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the + in the wheel name with a _. + is allowed in Python package names, but not in the trigger name or Docker image tag.

https://developer.hashicorp.com/terraform/language/functions/replace

b.python_version,
b.accelerator == "tpu" ? "tpuvm" : format("cuda_%s", b.cuda_version)
) => b
Expand Down