Skip to content

Conversation

@asuhan
Copy link
Contributor

@asuhan asuhan commented Apr 14, 2019

No description provided.

@asuhan asuhan requested review from ailzhang and dlibenzi April 14, 2019 01:28
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asuhan asuhan force-pushed the asuhan/fix_bindings_issue branch from 3b6a566 to 74a357c Compare April 14, 2019 02:35
@asuhan asuhan force-pushed the asuhan/fix_bindings_issue branch from 74a357c to 878a433 Compare April 14, 2019 03:05
@asuhan
Copy link
Contributor Author

asuhan commented Apr 14, 2019

Had to copy CreateGraphByTracing from torch/csrc/jit/python_tracer.cpp since it's part of libtorch_python.so. Other possible solutions are:

  1. Make torch_xla depend on libtorch_python.so. We already do this for our C++ tests, but I'm not sure how to do it for our Python extension.
  2. Simply disable the TestGradients tests from test_operations.py, they are the only users of this binding and we have plenty of operation coverage in our C++ tests.

Copy link
Collaborator

@dlibenzi dlibenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for #2 .. Disable Test Gradients.
With a possible extension ... remove JIT ;)
We can chat on the latter once I am back in MTV.

@asuhan asuhan merged commit c46e02d into master Apr 14, 2019
@asuhan asuhan deleted the asuhan/fix_bindings_issue branch April 14, 2019 06:31
@dlibenzi
Copy link
Collaborator

I vote for #2 .. Disable Test Gradients.
With a possible extension ... remove JIT ;)
We can chat on the latter once I am back in MTV.

I had said #2 actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants