Skip to content

Enable install google-cloud-sdk-gke-gcloud-auth-plugin to enable TPUCI run_e2e_tests#6420

Merged
ManfeiBai merged 3 commits intomasterfrom
ManfeiBai-patch-61
Feb 1, 2024
Merged

Enable install google-cloud-sdk-gke-gcloud-auth-plugin to enable TPUCI run_e2e_tests#6420
ManfeiBai merged 3 commits intomasterfrom
ManfeiBai-patch-61

Conversation

@ManfeiBai
Copy link
Copy Markdown
Collaborator

@ManfeiBai ManfeiBai commented Jan 30, 2024

since Jan30, TPU CI start to failed due to there is the existing google-cloud-cli-gke-gcloud-auth-plugin before install google-cloud-sdk-gke-gcloud-auth-plugin,

so to bring TPU-CI/CI green, confirm force install google-cloud-sdk-gke-gcloud-auth-plugin by --force-overwrite

@ManfeiBai ManfeiBai changed the title force install google-cloud-sdk-gke-gcloud-auth-plugin enable TPUCI run_e2e_tests Force install google-cloud-sdk-gke-gcloud-auth-plugin to enable TPUCI run_e2e_tests Jan 30, 2024
@ManfeiBai ManfeiBai marked this pull request as ready for review January 30, 2024 23:49
@JackCaoG
Copy link
Copy Markdown
Collaborator

Looking at the log it still does not have -y, I am guessing this pr will not take effect until it is merged. @will-cromar should we just merge it?

@will-cromar
Copy link
Copy Markdown
Collaborator

Correct, this change will only have an effect after it is merged.

Since the cause of our issue here is that google-cloud-sdk-gke-gcloud-auth-plugin is already installed (when it apparently was not before), should we just remove this apt-get install entirely?

@ManfeiBai
Copy link
Copy Markdown
Collaborator Author

ManfeiBai commented Feb 1, 2024

Correct, this change will only have an effect after it is merged.

Since the cause of our issue here is that google-cloud-sdk-gke-gcloud-auth-plugin is already installed (when it apparently was not before), should we just remove this apt-get install entirely?

thanks, the cause was google-cloud-cli-gke-gcloud-auth-plugin installed already, and we want to install a different plugin google-cloud-sdk-gke-gcloud-auth-plugin, so remove the old plugin and install the new plugin here

and since this change will only have an effect after it is merged, this PR looks like ready to be merged now

@ManfeiBai ManfeiBai merged commit 479559c into master Feb 1, 2024
@ManfeiBai ManfeiBai changed the title Force install google-cloud-sdk-gke-gcloud-auth-plugin to enable TPUCI run_e2e_tests Enable install google-cloud-sdk-gke-gcloud-auth-plugin to enable TPUCI run_e2e_tests Feb 1, 2024
ManfeiBai added a commit that referenced this pull request Feb 1, 2024
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants