Skip to content

remove using_pjrt in xla_graph_executor #6768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024
Merged

remove using_pjrt in xla_graph_executor #6768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions torch_xla/csrc/xla_graph_executor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,8 +1331,6 @@ XLAGraphExecutor::CompilationResult XLAGraphExecutor::Compile(
runtime::sys_util::GetEnvBool("XLA_ENABLE_PARAM_ALIASING", true);
static const size_t parameter_wrapping_threadshold =
runtime::sys_util::GetEnvInt("XLA_PARAMETER_WRAPPING_THREADSHOLD", 3200);
static const bool using_pjrt =
runtime::sys_util::GetEnvString("PJRT_DEVICE", "").size() > 0;
static const bool use_autosharding = ShardingUtil::GetAutoSharding();
LoweringContext lowering_ctx("SyncTensorsGraph", coll.device,
po_data->post_order,
Expand Down Expand Up @@ -1393,7 +1391,7 @@ XLAGraphExecutor::CompilationResult XLAGraphExecutor::Compile(
// TODO(yeounoh) enable wrapping with auto-sharding.
bool should_wrap_parameter =
(program_shape.parameters_size() >= parameter_wrapping_threadshold) &&
using_pjrt && !use_autosharding;
!use_autosharding;
if (should_wrap_parameter) {
TF_VLOG(3) << "Wrapping graph with " << program_shape.parameters_size()
<< " parameters. Threadshold = "
Expand Down