[Backport] Remove reshape lowering (#6801) #6847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
approved these changes
Mar 28, 2024
Collaborator
JackCaoG
left a comment
JackCaoG
left a comment
There was a problem hiding this comment.
Let's make sure torchbench data is up to date.
Collaborator
|
One GPU test is failing, now sure if it's persistent Triggered rerun on the failed GPU testing job. |
lsy323
approved these changes
Apr 3, 2024
Collaborator
lsy323
left a comment
lsy323
left a comment
There was a problem hiding this comment.
GPU test passed after rerunning, merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #6801.
After merging #6801 to nightly earlier this week, we didn't see any observable regression in our dashboards.
We'll keep monitoring for a few more days and merge this once we're confident that there is no regression according to our dashboards.