Skip to content

Adjust allclose atol for the flash attention TPU test #6889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Adjust allclose atol for the flash attention TPU test #6889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a673b2f
Adjust allclose atol for the flash attention TPU test
JackCaoG Apr 4, 2024
d7896b1
lint
JackCaoG Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/test_pallas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test_flash_attention_wrapper(self):

o = flash_attention(q, k, v)
expected_o = self._attention(q, k, v)
self.assertTrue(torch.allclose(o.cpu(), expected_o.cpu()))
self.assertTrue(torch.allclose(o.cpu(), expected_o.cpu(), atol=1e-05))
jax.config.update('jax_default_matmul_precision', jax.lax.Precision.DEFAULT)

@unittest.skipIf(xr.device_type() != 'TPU' or tpu.version() < 3,
Expand All @@ -230,7 +230,8 @@ def flash_attention_wrapper(q, k, v, causal=False):
# The causal mask is turned on by default in the wrapper.
# It masks out the top right triangle of the attention matrix,
# therefore it speeds up the compute but also changes the output.
self.assertFalse(torch.allclose(o_with_causal.cpu(), expected_o.cpu()))
self.assertFalse(
torch.allclose(o_with_causal.cpu(), expected_o.cpu(), atol=1e-05))
jax.config.update('jax_default_matmul_precision', jax.lax.Precision.DEFAULT)

@unittest.skipIf(xr.device_type() != 'TPU' or tpu.version() < 3,
Expand Down