Skip to content

Conversation

@ailzhang
Copy link
Contributor

@dlibenzi
Copy link
Collaborator

Ouch ... keep biting us:

RuntimeError: Attempted to call `variable.set_data(tensor)`, but `variable` and `tensor` have different types of TensorImpl.

@dlibenzi
Copy link
Collaborator

Oh, OK ... one HUNK failed:

+ xla/scripts/apply_patches.sh
1 out of 1 hunk FAILED
Applying patch file: /tmp/pytorch/xla/torch_patches/21048.diff

Is Will's new PR in?

@dlibenzi
Copy link
Collaborator

This PR though is benign enough to go in regardless.

@dlibenzi dlibenzi merged commit c368f8c into pytorch:master Jun 19, 2019
@ailzhang
Copy link
Contributor Author

@dlibenzi Yea the first PR of @yf225 's fix (pytorch/pytorch#21865) went in last night. And the last one (pytorch/pytorch#21613) is approved, should be merged soon I think. We can safely remove the patch after that. (We've tested it locally yesterday, should be good).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants