Skip to content

Conversation

@dlibenzi
Copy link
Collaborator

No description provided.

@dlibenzi dlibenzi requested a review from asuhan June 21, 2019 22:58
@asuhan
Copy link
Contributor

asuhan commented Jun 22, 2019

Didn't notice your PR, do you want to take #774 instead? I think we need overrides for all.

@dlibenzi
Copy link
Collaborator Author

Didn't notice your PR, do you want to take #774 instead? I think we need overrides for all.

This happened before already.
I sent you the diff on Slack, a PR to review an hour before.
Saying yes here encourages interesting behavioral patterns.

@asuhan asuhan merged commit 29306d8 into master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants