Skip to content

Remove unnecessary functions and print statements (#7495) #8352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Remove unnecessary functions and print statements (#7495) #8352

merged 1 commit into from
Nov 4, 2024

Conversation

@simonteozw
Copy link
Contributor

@simonteozw simonteozw commented Nov 3, 2024

Discovered aten::eye was unnecessary when working on issue #7495

ManfeiBai
ManfeiBai approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, why we notice its unnecessary?

@ManfeiBai
Copy link
Collaborator

ManfeiBai commented Nov 4, 2024

Thanks, why we notice its unnecessary?

Thanks, saw the reason in chat: basically matrix_power failed because aten_eye called arange an incorrect number of times.

@ManfeiBai ManfeiBai merged commit 57cce80 into pytorch:master Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManfeiBai ManfeiBai ManfeiBai approved these changes

Assignees

No one assigned

Labels

torchxla2-op torchxla2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonteozw @ManfeiBai